script

Question

Post reply

script

Best-330874

SSCrazy

Points: 2350
More actions
February 1, 2007 at 4:35 pm

#115838

Consider the following snippet of ASP script:

Set oConn = CreateObject("ADODB.Connection")
oConn.Open "MyDatabaseConnectionString"
departmentId = Request.QueryString("deptId")
sSql = "SELECT * FROM Employees" _
& "WHERE department_id=" & departmentId _
& "ORDER BY last_name, first_name"
Set oRs = oConn.Execute(sSql)

What issues exist in the above code? Consider both coding syntax as well as best practices.

Viewing 3 posts - 1 through 2 (of 2 total)

You must be logged in to reply to this topic. Login to reply

Sergiy SSC Guru Points: 110192 More actions · Answer 1

...

sSql = "EXEC dbo.DepartmentEmployees " _

& "@department_id = " & departmentId

Set oRs = oConn.Execute(sSql)

_____________
Code for TallyGenerator

Jeff Moden SSC Guru Points: 1000539 More actions · Answer 2

Considering your other post... this looks a lot like a take-home exam...

--Jeff Moden

RBAR is pronounced "ree-bar" and is a "Modenism" for Row-By-Agonizing-Row.
First step towards the paradigm shift of writing Set Based code:
________Stop thinking about what you want to do to a ROW... think, instead, of what you want to do to a COLUMN.
"Change is inevitable... change for the better is not".

Helpful Links:
How to post code problems
How to Post Performance Problems
Create a Tally Function (fnTally)
Intro to Tally Tables and Functions